enable sandboxing for tests #38
Conversation
| end) | ||
| |> TestRepo.transaction() | ||
| end | ||
| # "cannot open savepoint - SQL statements in progress" |
There was a problem hiding this comment.
Are you sure it is prepared statements or that we aren't releasing a save point correctly? I can dig more into this once we get this merged. Just want your thoughts.
There was a problem hiding this comment.
I added a log in handle_transaction to output the SQL and I couldn't see any case where we created a save point but did not release it. This error seems to be pretty rare, as I couldn't find anything via a search about it. If you look at sqlite.c:88847 it mentions something about "active write statements", hence my hypothesis.
There was a problem hiding this comment.
Cool, I'll see if I can reliably recreate the issue and dig around a bit
| end) | ||
| |> TestRepo.transaction() | ||
| end | ||
| # "cannot open savepoint - SQL statements in progress" |
There was a problem hiding this comment.
Cool, I'll see if I can reliably recreate the issue and dig around a bit
2 participants
I ran
mix testa bunch locally to make sure there are no intermittent failures, and did not hit any (but no guarantees).I hit an issue with rollback that was fixed by commenting out some extra conditions in a case, as you can see. Obviously not the long term fix, so feel free to adjust accordingly. Some issue with nested transactions, maybe.