fix delete specifying table qualifier #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @kevinlang hah I just came across this trying to fix the DELETE and UPDATE bug I found |
| I'm actually okay with that. It's probably best to keep this library strictly just the NIF and sqlite interactions. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
https://sqlite.org/lang_delete.html
I began an attempt to integrate your ecto driver into
ecto_sql, partly to make it easier to leverage their integration tests, and partly because that is probably where we may want it to be long term.https://github.com/kevinlang/ecto_sql/tree/exqlite
I'm curious of your thoughts on that approach. 💭
Ran into this when trying to run a couple of the integration tests. Looks like this approach will help us find a bunch of bugs.
Most of the tests are currently failing (in that
ecto_sqlrepo), but I think that is probably due to various sandbox-related bugs, and because I am not excluding a bunch of things that SQLite cannot support.