Automatically close the sidebar when navigating sections on mobile #2097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
|
Edit: sorry, I didn't see this is a pull request and not just an issue. Ignore me. Thanks, @mcky. |
Member
| @DavidOliver i am 80% sure this was the case in the past and it was changed because it would be undesired in many cases. It can double check later. |
| 📦 Docs artifacts are ready: https://github.com/elixir-lang/ex_doc/actions/runs/13911569984/artifacts/2768744820 |
Member
| Given we always close when navigating away, I think we should remain consistent, so let's give it a try! |
Member
| 💚 💙 💜 💛 ❤️ |
Contributor Author
| Thanks folks! 🥳 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I've been reading quite a few ExDoc sites from my mobile lately and I've found it slightly frustrating that clicking on some headings causes a full page change and the nav is closed, but within a module the sidebar stays open and it's unclear that you've even navigated
An example of the previous behaviour:
CleanShot.2025-03-17.at.22.31.00.mp4