reverse @__behaviour_docs__ #1461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
These are top accumlated as module attributes, so are therefore stored in reverse order to how they were added. When we get them back out, reverse them again so they're back in the right order. This is used by ex_doc, and callbacks are listed backwards otherwise
josevalim pushed a commit that referenced this pull request Jul 20, 2013
reverse @__behaviour_docs__
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Behaviour callback docs are top accumulated as module attributes, so are therefore stored internally in reverse order to how they were added.
However, they weren't being reversed again when being accessed, so ended up backwards.
Fix is to just reverse them when we get them back out to put them in the right order.
This is used by ex_doc, and callbacks are listed backwards otherwise (e.g. see http://elixir-lang.org/docs/stable/Dict.html )
Raised initially as elixir-lang/ex_doc#47 , but made fix here instead as recommended by @josevalim