Fix handling of ErlangError when :general key is chardata #14329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
josevalim reviewed Mar 15, 2025
| line: 53, | ||
| error_info: %{cause: :enoent, module: :pubkey_os_cacerts} | ||
| ]} | ||
| ]) |
There was a problem hiding this comment.
Given this will depend on the Erlang/OTP version, I wonder if we should write our own Erlang error that reproduces the failure?
There was a problem hiding this comment.
Woops right, there was an example just above reused the same approach: 39ea53e
josevalim approved these changes Mar 15, 2025
sabiwara added a commit to sabiwara/elixir that referenced this pull request Mar 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Close #14322
https://github.com/erlang/otp/blob/57cee857031cc08a47c7d2f4f21a6fac87781f91/lib/public_key/src/pubkey_os_cacerts.erl#L300
Before
After