Skip to content

Clarify upgrade path for Regex.regex? (#12785) #12786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 12, 2023
Merged

Clarify upgrade path for Regex.regex? (#12785) #12786

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
49d6ca1
Clarify upgrade path for Regex.regex? (#12785)
thbar Jul 12, 2023
fa71a01
Highlight upgrade path in the deprecation table
thbar Jul 12, 2023
2c91f64
Improve doc
thbar Jul 12, 2023
660e414
Improve doc
thbar Jul 12, 2023
0da437b
Update lib/elixir/pages/references/compatibility-and-deprecations.md
thbar Jul 12, 2023
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/elixir/lib/regex.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ defmodule Regex do
end

@doc false
@deprecated "Use Kernel.is_struct/2 or pattern match on %Regex{} instead"
@deprecated "Use Kernel.is_struct(xyz, Regex) or pattern match on %Regex{} instead"
def regex?(term)
def regex?(%Regex{}), do: true
def regex?(_), do: false
Expand Down
2 changes: 1 addition & 1 deletion lib/elixir/pages/references/compatibility-and-deprecations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ Version | Deprecated feature | Replaced by (ava
:-------| :-------------------------------------------------- | :---------------------------------------------------------------
[v1.15] | `Calendar.ISO.day_of_week/3` | `Calendar.ISO.day_of_week/4` (v1.11)
[v1.15] | `Exception.exception?/1` | `Kernel.is_exception/1` (v1.11)
[v1.15] | `Regex.regex?/1` | `Kernel.is_struct/2` (v1.11)
[v1.15] | `Regex.regex?/1` | `Kernel.is_struct/2` via `Kernel.is_struct(xyz, Regex)` (v1.11)
[v1.15] | `Logger.warn/2` | `Logger.warning/2` (v1.11)
[v1.14] | `use Bitwise` | `import Bitwise` (v1.0)
[v1.14] | `~~~/1` | `bnot/2` (v1.0)
Expand Down