fix indentation when following previous end block #351
+66 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The changes to limit the number of lines we search for a block have made it so that `def` calls in modules don't indent properly. This is because we're looking for the base module declaration as a reference point and stop searching before we get there Instead, we hack around a bit and try to detect this by looking for the last `end`. This solution isn't perfect, but it's cheap and effective until we find problems with it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The changes to limit the number of lines we search for a block have made
it so that
defcalls in modules don't indent properly. This is becausewe're looking for the base module declaration as a reference point and
stop searching before we get there
Instead, we hack around a bit and try to detect this by looking for
the last
end. This solution isn't perfect, but it's cheap and effectiveuntil we find problems with it