update readme with usage guidance. #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
typhoonzero approved these changes Mar 15, 2018
| then push it to docker hub to be accessible by Kubernetes: | ||
| | ||
| ``` bash | ||
| docker push yourRepoName/my_edl_training_job |
There was a problem hiding this comment.
Maybe add git clone command before head so that readers are not confused by yourRepoName
There was a problem hiding this comment.
agreed, will update with "Resource Adjustments by EDL" part and FAQ in next PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
fix: #1
Please do NOT merge until #7 is merged.
will add training job creating guidance.