Improve txn check based on remote flag for parent span #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
axw reviewed Jul 18, 2024
Comment on lines +273 to 284
| flags := tracepb.SpanFlags(span.Flags()) | ||
| switch { | ||
| case span.ParentSpanID().IsEmpty(): | ||
| return true | ||
| case (flags & tracepb.SpanFlags_SPAN_FLAGS_CONTEXT_HAS_IS_REMOTE_MASK) == 0: | ||
| // span parent is unknown, fall back to span kind | ||
| return span.Kind() == ptrace.SpanKindServer || span.Kind() == ptrace.SpanKindConsumer | ||
| case (flags & tracepb.SpanFlags_SPAN_FLAGS_CONTEXT_IS_REMOTE_MASK) != 0: | ||
| // span parent is remote | ||
| return true | ||
| } | ||
| return false |
lahsivjar force-pushed the enrichment-remotespan branch from fe1da3a to 8cfb0d1 Compare axw approved these changes Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Checks if parent span is remote to decide the nature of the OTel span (elastic txn or span).
Follow-up for #46 (to be merged after)
Related to: https://github.com/elastic/opentelemetry-dev/issues/304