Skip to content

remove k8s.node.* metrics remapping #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2024
Merged

remove k8s.node.* metrics remapping #45

merged 1 commit into from
Jul 10, 2024

Conversation

@tetianakravchenko
Copy link
Contributor

@tetianakravchenko tetianakravchenko commented Jul 10, 2024

No description provided.

@tetianakravchenko
remove k8s.node.* metrics remapping
29b45ba 
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
@tetianakravchenko tetianakravchenko requested a review from a team as a code owner July 10, 2024 13:44
@ChrsMark
Copy link
Member

ChrsMark commented Jul 10, 2024

Interestingly merging is blocked on approval(+merge?) from @elastic/obs-infraobs-integrations. However by looking into this group I wonder if that makes sense since most of the people are not really involved with the OTel initiative at the moment?
So @AlexanderWert would that make sense to give permissions to @elastic/otel-devs as well as make @tetianakravchenko and @gizas owners/approves of the k8s part?
lahsivjar
lahsivjar approved these changes Jul 10, 2024
View reviewed changes
Copy link
Contributor

@lahsivjar lahsivjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix.
@lahsivjar lahsivjar merged commit 58c4717 into elastic:main Jul 10, 2024
@AlexanderWert
Copy link
Member

AlexanderWert commented Jul 10, 2024

So @AlexanderWert would that make sense to give permissions to @elastic/otel-devs as well as make @tetianakravchenko and @gizas owners/approves of the k8s part?

yes absolutely! I just don't have the permissions on this repo. @elastic/observablt-robots Can you please give @elastic/otel-devs maintainer rights on this?
@reakaleek
Copy link
Member

reakaleek commented Jul 11, 2024

So @AlexanderWert would that make sense to give permissions to @elastic/otel-devs as well as make @tetianakravchenko and @gizas owners/approves of the k8s part?

yes absolutely! I just don't have the permissions on this repo. @elastic/observablt-robots Can you please give @elastic/otel-devs maintainer rights on this?

When https://github.com/elastic/catalog-info/pull/1236 is merged and if the next terrazzo build succeeds, then @elastic/otel-devs should be maintainers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

6 participants

@tetianakravchenko @ChrsMark @AlexanderWert @reakaleek @lahsivjar @gizas