Skip to content

Add event.dataset to all remapped metrics #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 5, 2024
Merged

Add event.dataset to all remapped metrics #41

merged 2 commits into from
Jul 5, 2024

Conversation

@lahsivjar
Copy link
Contributor

@lahsivjar lahsivjar commented Jul 5, 2024 •
edited
Loading

Unlike data_stream.dataset which doesn't need to be set for the APM path, the event.dataset is required for multiple UI panels. The PR allows setting the dataset in all cases and adopts the mutator pattern throughout the codebase.

There are no major logic changes other than all metrics having event.dataset set as a datapoint attribute.
@lahsivjar lahsivjar requested a review from a team as a code owner July 5, 2024 08:18
@lahsivjar lahsivjar requested review from carsonip and ishleenk17 July 5, 2024 08:21
ishleenk17
ishleenk17 approved these changes Jul 5, 2024
View reviewed changes
Copy link
Member

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good!
@ishleenk17 ishleenk17 merged commit 99cc650 into elastic:main Jul 5, 2024
@lahsivjar lahsivjar deleted the eventdataset branch July 5, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@lahsivjar @ishleenk17