[ML] Fix for SIGSEGV forecasting #1402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
tveasey added a commit to tveasey/ml-cpp-1 that referenced this pull request Jul 14, 2020
It is possible that a model which hasn't received any recent updates is removed. In this case, when forecasting we'd hit a null pointer dereference. This moves the offending code under the check that the model still exists.
tveasey added a commit to tveasey/ml-cpp-1 that referenced this pull request Jul 14, 2020
It is possible that a model which hasn't received any recent updates is removed. In this case, when forecasting we'd hit a null pointer dereference. This moves the offending code under the check that the model still exists.
This was referenced Jul 14, 2020
tveasey added a commit that referenced this pull request Jul 14, 2020
It is possible that a model which hasn't received any recent updates is removed. In this case, when forecasting we'd hit a null pointer dereference. This moves the offending code under the check that the model still exists. Backport #1402.
tveasey added a commit that referenced this pull request Jul 14, 2020
It is possible that a model which hasn't received any recent updates is removed. In this case, when forecasting we'd hit a null pointer dereference. This moves the offending code under the check that the model still exists. Backport #1402.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
It is possible that a model which hasn't received any recent updates is removed. In this case, when forecasting we'd hit a null pointer dereference. This moves the offending code under the check that the model still exists.
Fixes #1401.