[ML] Fix change detector restore #1391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The change detector would crash during restoration if seasonal components existed at the time it was originally created, but had been discarded by the time it was persisted. This change ensures that the change models within the change detector reflect the status of seasonality at the time of restoration from state.
tveasey approved these changes Jul 9, 2020
Contributor
tveasey left a comment
tveasey left a comment There was a problem hiding this comment.
Thanks for debugging this! LGTM.
droberts195 pushed a commit to droberts195/ml-cpp that referenced this pull request Jul 9, 2020
The change detector would crash during restoration if seasonal components existed at the time it was originally created, but had been discarded by the time it was persisted. This change ensures that the change models within the change detector reflect the status of seasonality at the time of restoration from state. Backport of elastic#1391
droberts195 pushed a commit to droberts195/ml-cpp that referenced this pull request Jul 9, 2020
The change detector would crash during restoration if seasonal components existed at the time it was originally created, but had been discarded by the time it was persisted. This change ensures that the change models within the change detector reflect the status of seasonality at the time of restoration from state. Backport of elastic#1391
droberts195 pushed a commit to droberts195/ml-cpp that referenced this pull request Jul 9, 2020
The change detector would crash during restoration if seasonal components existed at the time it was originally created, but had been discarded by the time it was persisted. This change ensures that the change models within the change detector reflect the status of seasonality at the time of restoration from state. Backport of elastic#1391
droberts195 pushed a commit that referenced this pull request Jul 9, 2020
The change detector would crash during restoration if seasonal components existed at the time it was originally created, but had been discarded by the time it was persisted. This change ensures that the change models within the change detector reflect the status of seasonality at the time of restoration from state. Backport of #1391
droberts195 pushed a commit that referenced this pull request Jul 9, 2020
The change detector would crash during restoration if seasonal components existed at the time it was originally created, but had been discarded by the time it was persisted. This change ensures that the change models within the change detector reflect the status of seasonality at the time of restoration from state. Backport of #1391
droberts195 pushed a commit that referenced this pull request Jul 10, 2020
The change detector would crash during restoration if seasonal components existed at the time it was originally created, but had been discarded by the time it was persisted. This change ensures that the change models within the change detector reflect the status of seasonality at the time of restoration from state. Backport of #1391
tveasey added a commit that referenced this pull request Jul 17, 2020
Change #1391 introduced a subtle error: when computing the likelihood of no change we should use a reference to the current time series trend model, not the copy of the model which assumes a change is occurring.
tveasey added a commit to tveasey/ml-cpp-1 that referenced this pull request Jul 17, 2020
Change elastic#1391 introduced a subtle error: when computing the likelihood of no change we should use a reference to the current time series trend model, not the copy of the model which assumes a change is occurring.
tveasey added a commit to tveasey/ml-cpp-1 that referenced this pull request Jul 17, 2020
Change elastic#1391 introduced a subtle error: when computing the likelihood of no change we should use a reference to the current time series trend model, not the copy of the model which assumes a change is occurring.
tveasey added a commit to tveasey/ml-cpp-1 that referenced this pull request Jul 17, 2020
Change elastic#1391 introduced a subtle error: when computing the likelihood of no change we should use a reference to the current time series trend model, not the copy of the model which assumes a change is occurring.
This was referenced Jul 17, 2020
tveasey added a commit to tveasey/ml-cpp-1 that referenced this pull request Jul 17, 2020
Change elastic#1391 introduced a subtle error: when computing the likelihood of no change we should use a reference to the current time series trend model, not the copy of the model which assumes a change is occurring.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The change detector would crash during restoration if seasonal
components existed at the time it was originally created, but
had been discarded by the time it was persisted.
This change ensures that the change models within the change
detector reflect the status of seasonality at the time of
restoration from state.