Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

No description provided.

@donoghuc donoghuc force-pushed the update_release_notes_1752530291 branch from 70c8900 to efabfce Compare July 24, 2025 17:52
@donoghuc donoghuc marked this pull request as ready for review July 24, 2025 17:53
@donoghuc donoghuc requested review from karenzone and robbavey July 24, 2025 17:53
Copy link
Contributor

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add some extra content for the ES|QL support, it's a cool feature, and I'd like to surface it more clearly


*Elasticsearch Input - 4.23.0*

* ES|QL support https://github.com/logstash-plugins/logstash-input-elasticsearch/pull/235[#235]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add a note about this to "New Features and Enhancements" to advertise more prominently - it's a pretty big new feature!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit establishes a pattern whereby for a new minor, the release notes from all the patch releases POST LAST MINOR (for example 8.18.1 -> 8.18.4) are included. This should make it easy to get the summary of what has been changing since the last minor version.
Copy link
Member

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'll need to add bullets here too

Co-authored-by: Rob Bavey <rob.bavey@elastic.co>
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
General comment (NOT blocking): We need to align on tense.

Co-authored-by: Rob Bavey <rob.bavey@elastic.co>
@donoghuc donoghuc requested a review from robbavey July 28, 2025 18:44
Co-authored-by: Rob Bavey <rob.bavey@elastic.co>
Co-authored-by: Rob Bavey <rob.bavey@elastic.co>
Co-authored-by: Rob Bavey <rob.bavey@elastic.co>
Copy link
Member

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@donoghuc donoghuc merged commit e40566c into 8.19 Jul 28, 2025
5 of 6 checks passed
@donoghuc donoghuc deleted the update_release_notes_1752530291 branch July 28, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants