FIX for the required gems when USE_JRUBY=1 https://logstash.jira.com/browse/LOGSTASH-1918 1.4.x #1099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Do we even need the |
| Have you completed step 2 of our Contribution Steps? |
| I'm ready to merge this after these are done. Thanks for making Logstash more awesome! |
| @untergeek I think we can ignore the Gemfile.lock change here; something caused it (previously) to have non-java gem information (weird?). bundler manages this file and we keep it checked in to help ensure versions are pinned and stable. +1 on the Gemfile.lock change |
| Good deal, then. Carry on. |
| CanBeClosed, as already fixed in #1164 |
| Can one of the admins verify this patch? |
jordansissel force-pushed the master branch from f86287d to a536eef Compare 
20 tasks
| @linuxonrails sorry for letting this dangle for so long |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.