Skip to content

[integrations] - Fixed ignore_malformed issues in multiple integration packages #9832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 13, 2024
Merged

[integrations] - Fixed ignore_malformed issues in multiple integration packages #9832

merged 5 commits into from
May 13, 2024

Conversation

@ShourieG
Copy link
Contributor

@ShourieG ShourieG commented May 10, 2024

Type of change

Please label this PR with one of the following labels, depending on the scope of your change:

  • Bug

Proposed commit message

Resolved ignore malformed issue in multiple integrations by updating the datatype to a more relevant type that suits the purpose.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@ShourieG ShourieG self-assigned this May 10, 2024
@ShourieG ShourieG added integration Label used for meta issues tracking each integration bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] 8.14 candidate labels May 10, 2024
@ShourieG ShourieG marked this pull request as ready for review May 10, 2024 07:23
@ShourieG ShourieG requested review from a team as code owners May 10, 2024 07:23
@elasticmachine
Copy link

elasticmachine commented May 10, 2024

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)
efd6
efd6 reviewed May 10, 2024
View reviewed changes
@elasticmachine
Copy link

elasticmachine commented May 10, 2024 •
edited
Loading

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
@elasticmachine
Copy link

elasticmachine commented May 10, 2024

💚 Build Succeeded

History

cc @ShourieG
@elastic-sonarqube
Copy link

elastic-sonarqube bot commented May 10, 2024

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube
taylor-swanson
taylor-swanson approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@taylor-swanson taylor-swanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM regarding sec-deployment-and-devices integrations.
@ShourieG ShourieG requested a review from efd6 May 11, 2024 04:47
@ShourieG ShourieG merged commit 98a8e95 into elastic:main May 13, 2024
@ShourieG ShourieG deleted the bugfix/ignore_malformed branch May 13, 2024 05:27
@elasticmachine
Copy link

elasticmachine commented May 13, 2024

Package crowdstrike - 1.34.2 containing this change is available at https://epr.elastic.co/search?package=crowdstrike
@elasticmachine
Copy link

elasticmachine commented May 13, 2024

Package fortinet_fortimanager - 2.11.1 containing this change is available at https://epr.elastic.co/search?package=fortinet_fortimanager
@elasticmachine
Copy link

elasticmachine commented May 13, 2024

Package m365_defender - 2.8.1 containing this change is available at https://epr.elastic.co/search?package=m365_defender
@elasticmachine
Copy link

elasticmachine commented May 13, 2024

Package panw - 3.25.1 containing this change is available at https://epr.elastic.co/search?package=panw
@elasticmachine
Copy link

elasticmachine commented May 13, 2024

Package tanium - 1.9.1 containing this change is available at https://epr.elastic.co/search?package=tanium
@elasticmachine
Copy link

elasticmachine commented May 13, 2024

Package tenable_io - 3.0.1 containing this change is available at https://epr.elastic.co/search?package=tenable_io
@elasticmachine
Copy link

elasticmachine commented May 13, 2024

Package ti_threatconnect - 0.5.1 containing this change is available at https://epr.elastic.co/search?package=ti_threatconnect
@andrewkroh andrewkroh added Integration:crowdstrike CrowdStrike Integration:fortinet_fortimanager Fortinet FortiManager Logs Integration:m365_defender Microsoft Defender XDR Integration:panw Palo Alto Next-Gen Firewall Integration:tanium Tanium Integration:tenable_io Tenable Vulnerability Management Integration:ti_threatconnect ThreatConnect (Partner supported) labels Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:crowdstrike CrowdStrike Integration:fortinet_fortimanager Fortinet FortiManager Logs Integration:m365_defender Microsoft Defender XDR Integration:panw Palo Alto Next-Gen Firewall Integration:tanium Tanium Integration:tenable_io Tenable Vulnerability Management Integration:ti_threatconnect ThreatConnect (Partner supported) integration Label used for meta issues tracking each integration Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

5 participants

@ShourieG @elasticmachine @efd6 @taylor-swanson @andrewkroh