Skip ignored fields check for offending data streams #9823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jsoriano approved these changes May 9, 2024
🚀 Benchmarks reportPackage |
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
scan | 20000 | 11363.64 | -8636.36 (-43.18%) | 💔 |
To see the full report comment with /test benchmark fullreport
|
💚 Build Succeeded
|
andrewkroh approved these changes May 9, 2024
ishleenk17 approved these changes May 13, 2024
This was referenced May 14, 2024
andrewkroh added Integration:fortinet_fortimanager Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Proposed commit message
elastic/elastic-package#1738 is adding a check to
elastic-packagesystem tests to validate that no documents are degraded (which means at least one field didn't get indexed correctly and ended up ignored).As there are a bunch of existing issues this check is highlighting (see #9696 and #9572), this PR is skipping the check for these fields to allow rolling out the check while fixing the issues in parallel.
This addition will currently have no effect at all, but will make sure the release of elastic/elastic-package#1738 won't break the build for these packages.
Checklist
I have verified that all data streams collect metrics or logs.I have added an entry to my package'schangelog.ymlfile.I have verified that Kibana version constraints are current according to guidelines.