sentinel_one_cloud_funnel: fix original data preservation for gcs #9627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
efd6 added bug efd6 force-pushed the sentinel_one_gcs_preserve_original branch from 8fdfad4 to ead9898 Compare 
🚀 Benchmarks reportTo see the full report comment with |
| Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
kcreddy approved these changes Apr 17, 2024
Contributor
kcreddy left a comment
kcreddy left a comment There was a problem hiding this comment.
Minor suggestion. LGTM 👍🏼
Contributor
There was a problem hiding this comment.
Suggested change
| type: enhancement | |
| type: bugfix |
I see based on patch version increment and also based on labels that its supposed to be bugfix?
efd6 force-pushed the sentinel_one_gcs_preserve_original branch from ead9898 to 4616d38 Compare 💚 Build Succeeded
History
cc @efd6 |
|
| Package sentinel_one_cloud_funnel - 0.14.1 containing this change is available at https://epr.elastic.co/search?package=sentinel_one_cloud_funnel |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Proposed commit message
See title.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots