Skip to content

Conversation

@taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented Apr 16, 2024

This is part 2 of a 2 part change. This PR improves the ECS categorizations for various message types. Existing messages have been improved and new message types have been added where necessary.

For an overview of the different message types, see this spreadsheet.

Proposed commit message

  • Improve ECS categorizations for messages

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

cd packages/cisco_asa elastic-package test 

Related issues

@taylor-swanson taylor-swanson added enhancement New feature or request Integration:cisco_asa Cisco ASA Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices] labels Apr 16, 2024
@taylor-swanson taylor-swanson self-assigned this Apr 16, 2024
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

- Improve ECS categorizations for messages
@taylor-swanson taylor-swanson marked this pull request as ready for review April 23, 2024 13:18
@taylor-swanson taylor-swanson requested a review from a team as a code owner April 23, 2024 13:18
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

"304001":
type: [ connection, allowed ]
type: [ access, allowed ]
action: url-access
Copy link
Contributor

@gogochan gogochan Apr 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Google sheet, event.action is firewall-rule, but here, it is url-access. I don't think this was noted anywhere. It would be helpful it is.

type: [ connection, denied ]
action: drop
outcome: unknown
type: [ denied ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on google sheet, it says connection for type.

@taylor-swanson
Copy link
Contributor Author

I think the table of mappings I had is a bit out of date. I think I need to do a run through again and make sure everything's up-to-date.

@taylor-swanson taylor-swanson marked this pull request as draft April 23, 2024 18:51
@taylor-swanson
Copy link
Contributor Author

/test

@taylor-swanson taylor-swanson marked this pull request as ready for review April 29, 2024 18:01
@taylor-swanson
Copy link
Contributor Author

A few changes I made:

  • The spreadsheet and pipeline should now be in sync with each other
  • Split the script into two, one for outcome-based assignment, and one for general assignment.
  • Improved categorizations here and there, but feel free to comment in either the pipeline or spreadsheet.

Overall, I think event.action may need some additional review, but the other categorizations should be good at this point.

Copy link
Contributor

@pkoutsovasilis pkoutsovasilis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except one question I added, this LGTM

Copy link
Contributor

@jrmolin jrmolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @taylor-swanson

@taylor-swanson taylor-swanson merged commit a5d082a into elastic:main May 15, 2024
@taylor-swanson taylor-swanson deleted the enhance/cisco-asa-apply-categorizations branch May 15, 2024 13:54
@elasticmachine
Copy link

Package cisco_asa - 2.34.0 containing this change is available at https://epr.elastic.co/search?package=cisco_asa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:cisco_asa Cisco ASA Team:Security-Deployment and Devices DEPRECATED Deployment and Devices Security team [elastic/sec-deployment-and-devices]

5 participants