Skip to content

[aws_logs] Add custom settings variable #9512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 24, 2024
Merged

[aws_logs] Add custom settings variable #9512

merged 2 commits into from
Apr 24, 2024

Conversation

@andrewkroh
Copy link
Member

Proposed commit message

Add a custom variable to allow passing additional settings to the input.

Closes #9509

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues
@andrewkroh
aws_logs - Add custom settings variable
d88194a 
Add a `custom` variable to allow passing additional settings to the input. Closes #9509
@andrewkroh
add changelog
30720b9
@andrewkroh andrewkroh added enhancement New feature or request Integration:aws AWS labels Apr 3, 2024
@andrewkroh andrewkroh marked this pull request as ready for review April 3, 2024 17:33
@andrewkroh andrewkroh requested a review from a team as a code owner April 3, 2024 17:33
@andrewkroh andrewkroh mentioned this pull request Apr 3, 2024
Closed
@elasticmachine
Copy link

💚 Build Succeeded
@elastic-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube
@andrewkroh
Copy link
Member Author

@elastic/obs-ds-hosted-services, could you please take a look at this PR.
kaiyan-sheng
kaiyan-sheng approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Do we need to give an example on hwo to use the custom setting?
@andrewkroh
Copy link
Member Author

I don't feel a strong need to include a default value containing commented out examples. The linked documentation has plenty.
@andrewkroh andrewkroh merged commit d3f421b into elastic:main Apr 24, 2024
@elasticmachine
Copy link

Package aws_logs - 1.2.0 containing this change is available at https://epr.elastic.co/search?package=aws_logs
gizas pushed a commit that referenced this pull request Apr 26, 2024
@andrewkroh @gizas
[aws_logs] Add custom settings variable (#9512)
ebc0612 
Add a `custom` variable to allow passing additional settings to the input. Closes #9509
@andrewkroh andrewkroh added Integration:aws_logs Custom AWS Logs and removed Integration:aws AWS labels Jul 22, 2024
qcorporation pushed a commit that referenced this pull request Feb 3, 2025
@andrewkroh @gizas
[aws_logs] Add custom settings variable (#9512)
c80035f 
Add a `custom` variable to allow passing additional settings to the input. Closes #9509
qcorporation pushed a commit that referenced this pull request Feb 4, 2025
@andrewkroh @gizas
[aws_logs] Add custom settings variable (#9512)
7f35bb0 
Add a `custom` variable to allow passing additional settings to the input. Closes #9509
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:aws_logs Custom AWS Logs

3 participants

@andrewkroh @elasticmachine @kaiyan-sheng