[trendmicro] Add ECS Categorization for Anti-malware Events #9407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jamiehynds added Team:Service-Integrations 
kcreddy reviewed Mar 21, 2024
| on_failure: | ||
| - append: | ||
| field: error.message | ||
| value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag fail-{{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}' |
There was a problem hiding this comment.
Suggested change
| value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag fail-{{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}' | |
| value: 'Processor {{{_ingest.on_failure_processor_type}}} with tag {{{_ingest.on_failure_processor_tag}}} in pipeline {{{_ingest.pipeline}}} failed with message: {{{_ingest.on_failure_message}}}' |
| /test |
🚀 Benchmarks reportTo see the full report comment with |
Removed 'fail-' from error.message.
| /test |
💚 Build Succeeded
History
|
|
100.0% Coverage on New Code
0.0% Duplication on New Code | Package trendmicro - 2.2.0 containing this change is available at https://epr.elastic.co/search?package=trendmicro |
narph added Team:Security-Service Integrations | Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Type of change
What does this PR do?
Add ECS categorizations for anti-malware events.
Based on guidance from Trend Micro, we have categorized the below-mentioned event id's as malware alerts (i.e.
event.category : malware,event.type: info,event.kind: alert)IDs = [4000000, 4000001, 4000002, 4000003, 4000010, 4000011, 4000012, 4000013, 4000020, 4000030]
Checklist
changelog.ymlfile.All changes
How to test this PR locally
Clone integrations repo.
Install the elastic package locally.
Start the elastic stack using the elastic package.
Move to integrations/packages/trendmicro directory.
Run the following command to run tests.
elastic-package test -vRelated issues
Automated Test
test-trend-micro_2.2.0.log