[panw] Ensure empty NAT IP is not appended to related items #9333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- Ensure that the NAT ip and port are removed prior to other processors if they are unset (values of '0.0.0.0' and '0', respectively) - Update test files, sample_event, and readme
taylor-swanson added bug 
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
|
|
100.0% Coverage on New Code
0.0% Duplication on New Code | Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
jrmolin approved these changes Mar 12, 2024
Contributor
jrmolin left a comment
jrmolin left a comment There was a problem hiding this comment.
So this was happening too late in the pipeline?
Contributor Author
Correct, the remove processors were at the end, but there were some append processors before it that added the nat ip to related.ip. |
| Package panw - 3.23.1 containing this change is available at https://epr.elastic.co/search?package=panw |
gizas pushed a commit that referenced this pull request Mar 13, 2024
- Ensure that the NAT ip and port are removed prior to other processors if they are unset (values of '0.0.0.0' and '0', respectively) - Update test files, sample_event, and readme
4 tasks
qcorporation pushed a commit that referenced this pull request Feb 3, 2025
- Ensure that the NAT ip and port are removed prior to other processors if they are unset (values of '0.0.0.0' and '0', respectively) - Update test files, sample_event, and readme
qcorporation pushed a commit that referenced this pull request Feb 4, 2025
- Ensure that the NAT ip and port are removed prior to other processors if they are unset (values of '0.0.0.0' and '0', respectively) - Update test files, sample_event, and readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
changelog.ymlfile.How to test this PR locally
Related issues