Skip to content

Set sensitive values as secret - Part 4 #9129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
taylor-swanson merged 2 commits into from
Feb 22, 2024
Merged

Set sensitive values as secret - Part 4 #9129

taylor-swanson merged 2 commits into from
Feb 22, 2024

Conversation

@taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented Feb 12, 2024 •
edited
Loading

Proposed commit message

  • Set sensitive values as secret in integrations.
  • Updated package-spec to 3.0.2 in most packages to leverage secrets validation checks.
  • Certain packages required fixes to mappings (due to missing or incorrect mappings).
  • Certain packages were not able to go to package-spec 3.0.2 due issues with dynamic mappings. These have been held back at 3.0.0.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

  • Relates elastic/security-team#7388
@taylor-swanson taylor-swanson self-assigned this Feb 12, 2024
@taylor-swanson taylor-swanson added enhancement New feature or request Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Feb 12, 2024
@elasticmachine
Copy link

elasticmachine commented Feb 12, 2024 •
edited
Loading

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
@taylor-swanson taylor-swanson marked this pull request as ready for review February 12, 2024 17:32
@taylor-swanson taylor-swanson requested a review from a team as a code owner February 12, 2024 17:32
@elasticmachine
Copy link

elasticmachine commented Feb 12, 2024

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)
kcreddy
kcreddy approved these changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼
@elasticmachine
Copy link

elasticmachine commented Feb 22, 2024

💚 Build Succeeded

History

cc @taylor-swanson
@elastic-sonarqube
Copy link

elastic-sonarqube bot commented Feb 22, 2024

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube
@taylor-swanson taylor-swanson merged commit e564102 into elastic:main Feb 22, 2024
@taylor-swanson taylor-swanson deleted the feature/secret-values-svc-4 branch February 22, 2024 14:39
@elasticmachine
Copy link

elasticmachine commented Feb 22, 2024

Package ti_anomali - 1.20.0 containing this change is available at https://epr.elastic.co/search?package=ti_anomali
@elasticmachine
Copy link

elasticmachine commented Feb 22, 2024

Package ti_cif3 - 1.11.0 containing this change is available at https://epr.elastic.co/search?package=ti_cif3
@elasticmachine
Copy link

elasticmachine commented Feb 22, 2024

Package ti_cybersixgill - 1.26.0 containing this change is available at https://epr.elastic.co/search?package=ti_cybersixgill
@elasticmachine
Copy link

elasticmachine commented Feb 22, 2024

Package ti_maltiverse - 1.1.0 containing this change is available at https://epr.elastic.co/search?package=ti_maltiverse
@elasticmachine
Copy link

elasticmachine commented Feb 22, 2024

Package ti_mandiant_advantage - 1.1.0 containing this change is available at https://epr.elastic.co/search?package=ti_mandiant_advantage
@elasticmachine
Copy link

elasticmachine commented Feb 22, 2024

Package ti_misp - 1.32.0 containing this change is available at https://epr.elastic.co/search?package=ti_misp
@elasticmachine
Copy link

elasticmachine commented Feb 22, 2024

Package ti_opencti - 2.1.0 containing this change is available at https://epr.elastic.co/search?package=ti_opencti
@elasticmachine
Copy link

elasticmachine commented Feb 22, 2024

Package ti_otx - 1.24.0 containing this change is available at https://epr.elastic.co/search?package=ti_otx
@elasticmachine
Copy link

elasticmachine commented Feb 22, 2024

Package ti_rapid7_threat_command - 1.15.0 containing this change is available at https://epr.elastic.co/search?package=ti_rapid7_threat_command
@elasticmachine
Copy link

elasticmachine commented Feb 22, 2024

Package ti_recordedfuture - 1.22.0 containing this change is available at https://epr.elastic.co/search?package=ti_recordedfuture
@elasticmachine
Copy link

elasticmachine commented Feb 22, 2024

Package ti_threatq - 1.25.0 containing this change is available at https://epr.elastic.co/search?package=ti_threatq
@elasticmachine
Copy link

elasticmachine commented Feb 22, 2024

Package tines - 1.10.0 containing this change is available at https://epr.elastic.co/search?package=tines
@elasticmachine
Copy link

elasticmachine commented Feb 22, 2024

Package trellix_edr_cloud - 1.1.0 containing this change is available at https://epr.elastic.co/search?package=trellix_edr_cloud
@elasticmachine
Copy link

elasticmachine commented Feb 22, 2024

Package trellix_epo_cloud - 1.10.0 containing this change is available at https://epr.elastic.co/search?package=trellix_epo_cloud
@elasticmachine
Copy link

elasticmachine commented Feb 22, 2024

Package trend_micro_vision_one - 1.16.0 containing this change is available at https://epr.elastic.co/search?package=trend_micro_vision_one
@elasticmachine
Copy link

elasticmachine commented Feb 22, 2024

Package wiz - 1.1.0 containing this change is available at https://epr.elastic.co/search?package=wiz
@elasticmachine
Copy link

elasticmachine commented Feb 22, 2024

Package zerofox - 1.23.0 containing this change is available at https://epr.elastic.co/search?package=zerofox
@elasticmachine
Copy link

elasticmachine commented Feb 22, 2024

Package zeronetworks - 1.12.0 containing this change is available at https://epr.elastic.co/search?package=zeronetworks
@elasticmachine
Copy link

elasticmachine commented Feb 22, 2024

Package zoom - 1.19.0 containing this change is available at https://epr.elastic.co/search?package=zoom
@elasticmachine
Copy link

elasticmachine commented Feb 22, 2024

Package zscaler_zia - 2.19.0 containing this change is available at https://epr.elastic.co/search?package=zscaler_zia
gizas pushed a commit that referenced this pull request Mar 13, 2024
@taylor-swanson @gizas
Set sensitive values as secret - Part 4 (#9129)
a4ac195 
- Set sensitive values as secret in integrations. - Updated package-spec to 3.0.2 in most packages to leverage secrets validation checks. - Certain packages required fixes to mappings (due to missing or incorrect mappings). - Certain packages were not able to go to package-spec 3.0.2 due to issues with dynamic mappings. These have been held back at 3.0.0.
@andrewkroh andrewkroh added Integration:tines Tines (Community supported) Integration:trellix_epo_cloud Trellix ePO Cloud Integration:trend_micro_vision_one Trend Micro Vision One Integration:ti_anomali Anomali Integration:ti_cybersixgill Cybersixgill Integration:ti_mandiant_advantage Mandiant Advantage (Partner supported) Integration:trellix_edr_cloud Trellix EDR Cloud Integration:zeronetworks Zero Networks (Partner supported) Integration:ti_cif3 Collective Intelligence Framework v3 (Community supported) Integration:ti_otx AlienVault OTX Integration:ti_recordedfuture Recorded Future Integration:wiz Wiz Integration:ti_maltiverse Maltiverse (Partner supported) Integration:ti_misp MISP Integration:ti_opencti OpenCTI Integration:zoom Zoom Integration:zscaler_zia Zscaler Internet Access Integration:ti_rapid7_threat_command Rapid7 Threat Command (Partner supported) Integration:ti_threatq ThreatQuotient (Partner supported) Integration:zerofox ZeroFox (Partner supported) labels Jul 22, 2024
qcorporation pushed a commit that referenced this pull request Feb 3, 2025
@taylor-swanson @gizas
Set sensitive values as secret - Part 4 (#9129)
cc4aa97 
- Set sensitive values as secret in integrations. - Updated package-spec to 3.0.2 in most packages to leverage secrets validation checks. - Certain packages required fixes to mappings (due to missing or incorrect mappings). - Certain packages were not able to go to package-spec 3.0.2 due to issues with dynamic mappings. These have been held back at 3.0.0.
qcorporation pushed a commit that referenced this pull request Feb 4, 2025
@taylor-swanson @gizas
Set sensitive values as secret - Part 4 (#9129)
878c62b 
- Set sensitive values as secret in integrations. - Updated package-spec to 3.0.2 in most packages to leverage secrets validation checks. - Certain packages required fixes to mappings (due to missing or incorrect mappings). - Certain packages were not able to go to package-spec 3.0.2 due to issues with dynamic mappings. These have been held back at 3.0.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:ti_anomali Anomali Integration:ti_cif3 Collective Intelligence Framework v3 (Community supported) Integration:ti_cybersixgill Cybersixgill Integration:ti_maltiverse Maltiverse (Partner supported) Integration:ti_mandiant_advantage Mandiant Advantage (Partner supported) Integration:ti_misp MISP Integration:ti_opencti OpenCTI Integration:ti_otx AlienVault OTX Integration:ti_rapid7_threat_command Rapid7 Threat Command (Partner supported) Integration:ti_recordedfuture Recorded Future Integration:ti_threatq ThreatQuotient (Partner supported) Integration:tines Tines (Community supported) Integration:trellix_edr_cloud Trellix EDR Cloud Integration:trellix_epo_cloud Trellix ePO Cloud Integration:trend_micro_vision_one Trend Micro Vision One Integration:wiz Wiz Integration:zerofox ZeroFox (Partner supported) Integration:zeronetworks Zero Networks (Partner supported) Integration:zoom Zoom Integration:zscaler_zia Zscaler Internet Access Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

4 participants

@taylor-swanson @elasticmachine @kcreddy @andrewkroh