ping_one: fix handling of potentially null method call receivers #9076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
efd6 added bugfix 
39 tasks
| Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
chrisberkhout requested changes Feb 8, 2024
| - append: | ||
| field: event.type | ||
| if: ctx.json?.action?.type?.toLowerCase().contains('created') | ||
| if: ctx.json?.action?.type?.toLowerCase().contains('created') == true |
Contributor
There was a problem hiding this comment.
One more after .toLowerCase():
ctx.json?.action?.type?.toLowerCase()?.contains('created') == true Below as well.
💚 Build Succeeded
History
cc @efd6 |
|
83.3% Coverage on New Code
0.0% Duplication on New Code chrisberkhout approved these changes Feb 12, 2024
| Package ping_one - 1.13.2 containing this change is available at https://epr.elastic.co/search?package=ping_one |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Proposed commit message
See title.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
nullhandling inifconditions and elsewhere #8646Screenshots