Skip to content

o365: prevent tenant ID being rendered into debug logs #9017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2024
Merged

o365: prevent tenant ID being rendered into debug logs #9017

merged 1 commit into from
Jan 31, 2024

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented Jan 31, 2024

Proposed commit message

This also allows secret annotation to be able to be informed about this field when that is implemented, preventing it being rendered into configs.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@efd6 efd6 added Integration:o365 Microsoft Office 365 bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels Jan 31, 2024
@efd6 efd6 self-assigned this Jan 31, 2024
@efd6
o365: prevent tenant ID being rendered into debug logs
b1a5895 
This also allows secret annotation to be able to be informed about this field when that is implemented, preventing it being rendered into configs.
@elasticmachine
Copy link

elasticmachine commented Jan 31, 2024

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
@elasticmachine
Copy link

elasticmachine commented Jan 31, 2024

💚 Build Succeeded

cc @efd6
@efd6 efd6 marked this pull request as ready for review January 31, 2024 02:46
@efd6 efd6 requested a review from a team as a code owner January 31, 2024 02:46
@elasticmachine
Copy link

elasticmachine commented Jan 31, 2024

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)
ShourieG
ShourieG approved these changes Jan 31, 2024
View reviewed changes
Copy link
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@efd6 efd6 merged commit f7ebd38 into elastic:main Jan 31, 2024
@elasticmachine
Copy link

elasticmachine commented Jan 31, 2024

Package o365 - 2.2.1 containing this change is available at https://epr.elastic.co/search?package=o365
@efd6 efd6 deleted the o365_shhh branch February 5, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:o365 Microsoft Office 365 Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]

3 participants

@efd6 @elasticmachine @ShourieG