Skip to content

[backport] [aws] Remove hardcoded event.dataset field and use ECS field instead #8888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zmoog merged 4 commits into from
Jan 17, 2024
Merged

[backport] [aws] Remove hardcoded event.dataset field and use ECS field instead #8888

zmoog merged 4 commits into from
Jan 17, 2024

Conversation

@zmoog
Copy link
Contributor

@zmoog zmoog commented Jan 15, 2024 •
edited
Loading

Proposed commit message

Backport #8811 to 8.8.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
@zmoog
Copy link
Contributor Author

zmoog commented Jan 15, 2024

/test
@zmoog zmoog self-assigned this Jan 16, 2024
@zmoog
Add missing tags to AWS resources
e2df9d7 
Tags are required to properly set up cloud resource on the CI infrastructure.
@elasticmachine
Copy link

elasticmachine commented Jan 16, 2024

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport
@zmoog zmoog marked this pull request as ready for review January 16, 2024 18:17
@zmoog zmoog requested a review from a team as a code owner January 16, 2024 18:17
kaiyan-sheng
kaiyan-sheng reviewed Jan 16, 2024
View reviewed changes
@zmoog
Copy link
Contributor Author

zmoog commented Jan 16, 2024

/test
3 similar comments
@zmoog
Copy link
Contributor Author

zmoog commented Jan 16, 2024

/test
@zmoog
Copy link
Contributor Author

zmoog commented Jan 17, 2024

/test
@zmoog
Copy link
Contributor Author

zmoog commented Jan 17, 2024

/test
@elasticmachine
Copy link

elasticmachine commented Jan 17, 2024

💚 Build Succeeded

History

cc @zmoog
@zmoog zmoog merged commit c7d6de4 into elastic:backport-aws-1.51 Jan 17, 2024
@zmoog zmoog deleted the zmoog/backport-remove-hardcoded-event-dataset branch January 17, 2024 16:50
@elasticmachine
Copy link

elasticmachine commented Jan 17, 2024

Package aws - 1.51.3 containing this change is available at https://epr.elastic.co/search?package=aws
@zmoog zmoog mentioned this pull request Jan 17, 2024
Merged
4 tasks
qcorporation pushed a commit that referenced this pull request Feb 4, 2025
@zmoog
[backport] [aws] Remove hardcoded event.dataset field and use ECS fie…
87b84d5 
…ld instead (#8888) * [aws] Remove hardcoded event.dataset field and use ECS field instead Backport #8811 to 8.8. * Add missing tags to AWS resources Tags are required to properly set up cloud resource on the CI infrastructure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:aws AWS

4 participants

@zmoog @elasticmachine @kaiyan-sheng @andrewkroh