Skip to content

Conversation

@kgeller
Copy link
Contributor

@kgeller kgeller commented Nov 13, 2023

Proposed commit message

This PR adds the first phase of the new Cribl integration.

This integration is unique in that it 1) has no input to run, since Cribl pushes data directly to elasticsearch via the _bulk API via their elasticsearch output, and 2) it doesn't really have its own pipeline, since the goal is to utilize existing integration's pipelines. It enables users to utilize the reroute processor to 'forward' logs from Cribl to a specific integration's datastream.

This first phase contains mostly documentation on how to set everything up using a custom pipeline. The second phase will contain a more elegant UI so that users can have a simpler experience configuring.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

The steps to set everything up are documented in the integration's README

Then I just utilized the _bulk API (since that's what the cribl output uses) to verify the routing works

Related issues

Screenshots

Integration main view main
Instructions 1 2p1 2p2 3
@kgeller kgeller added enhancement New feature or request Team:Security-External Integrations New Integration Issue or pull request for creating a new integration package. labels Nov 13, 2023
@kgeller kgeller self-assigned this Nov 13, 2023
@kgeller kgeller changed the title Add 'cribl' integration package Add cribl integration package Nov 13, 2023
@elasticmachine
Copy link

elasticmachine commented Nov 13, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-12-04T17:52:50.178+0000

  • Duration: 15 min 12 sec

Test stats 🧪

Test Results
Failed 0
Passed 2
Skipped 0
Total 2

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Nov 13, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 25.0% (1/4) 👍
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚
@kgeller kgeller marked this pull request as ready for review November 22, 2023 18:39
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@kgeller kgeller requested a review from a team November 27, 2023 13:58
Copy link
Contributor

@taylor-swanson taylor-swanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment about the ECS version, otherwise LGTM

@kgeller kgeller merged commit c82487d into elastic:main Dec 7, 2023
@kgeller kgeller deleted the 7723-cribl-integration branch December 7, 2023 14:13
@elasticmachine
Copy link

Package cribl - 0.1.0 containing this change is available at https://epr.elastic.co/search?package=cribl

@elasticmachine
Copy link

Package cribl - 0.1.1 containing this change is available at https://epr.elastic.co/search?package=cribl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:cribl Cribl New Integration Issue or pull request for creating a new integration package.

4 participants