Skip to content

Conversation

@kcreddy
Copy link
Contributor

@kcreddy kcreddy commented Nov 1, 2023

Proposed commit message

  • Support usernames ending with "$".
  • Add "User was not found" as reason to 113015.
  • Allow source to be a domain or an IP inside 313005.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

$ elastic-package stack down && elastic-package build && elastic-package stack up --version=8.10.3 -d -v && eval "$(elastic-package stack shellinit)" && elastic-package test pipeline --generate

--- Test results for package: cisco_asa - START --- ╭───────────┬─────────────┬───────────┬──────────────────────────────┬────────┬──────────────╮ │ PACKAGE │ DATA STREAM │ TEST TYPE │ TEST NAME │ RESULT │ TIME ELAPSED │ ├───────────┼─────────────┼───────────┼──────────────────────────────┼────────┼──────────────┤ │ cisco_asa │ log │ pipeline │ test-additional-messages.log │ PASS │ 24.880334ms │ │ cisco_asa │ log │ pipeline │ test-anyconnect-messages.log │ PASS │ 13.848584ms │ │ cisco_asa │ log │ pipeline │ test-asa-fix.log │ PASS │ 20.831959ms │ │ cisco_asa │ log │ pipeline │ test-asa-missing-groups.log │ PASS │ 4.83025ms │ │ cisco_asa │ log │ pipeline │ test-asa.log │ PASS │ 64.129625ms │ │ cisco_asa │ log │ pipeline │ test-dap-records.log │ PASS │ 5.837542ms │ │ cisco_asa │ log │ pipeline │ test-filtered.log │ PASS │ 11.230458ms │ │ cisco_asa │ log │ pipeline │ test-hostnames.log │ PASS │ 5.51525ms │ │ cisco_asa │ log │ pipeline │ test-non-canonical.log │ PASS │ 26.248625ms │ │ cisco_asa │ log │ pipeline │ test-not-ip.log │ PASS │ 13.344916ms │ │ cisco_asa │ log │ pipeline │ test-sample.log │ PASS │ 38.103709ms │ │ cisco_asa │ log │ pipeline │ test-sgt-tag-name.log │ PASS │ 25.674667ms │ │ cisco_asa │ log │ pipeline │ test-sip.log │ PASS │ 7.835833ms │ ╰───────────┴─────────────┴───────────┴──────────────────────────────┴────────┴──────────────╯ --- Test results for package: cisco_asa - END --- Done 

Related issues

Screenshots

@kcreddy kcreddy self-assigned this Nov 1, 2023
@kcreddy kcreddy added Integration:cisco_asa Cisco ASA bugfix Pull request that fixes a bug issue labels Nov 1, 2023
@elasticmachine
Copy link

elasticmachine commented Nov 1, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-01T09:17:40.282+0000

  • Duration: 17 min 8 sec

Test stats 🧪

Test Results
Failed 0
Passed 24
Skipped 0
Total 24

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Nov 1, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 94.444% (17/18) 👎 -5.556
Lines 69.643% (1599/2296) 👎 -25.509
Conditionals 100.0% (0/0) 💚
@kcreddy kcreddy marked this pull request as ready for review November 1, 2023 08:07
@kcreddy kcreddy requested a review from a team as a code owner November 1, 2023 08:07
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@kcreddy kcreddy merged commit faa1e0e into elastic:main Nov 1, 2023
@elasticmachine
Copy link

Package cisco_asa - 2.27.1 containing this change is available at https://epr.elastic.co/search?package=cisco_asa

3 similar comments
@elasticmachine
Copy link

Package cisco_asa - 2.27.1 containing this change is available at https://epr.elastic.co/search?package=cisco_asa

@elasticmachine
Copy link

Package cisco_asa - 2.27.1 containing this change is available at https://epr.elastic.co/search?package=cisco_asa

@elasticmachine
Copy link

Package cisco_asa - 2.27.1 containing this change is available at https://epr.elastic.co/search?package=cisco_asa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:cisco_asa Cisco ASA

3 participants