Skip to content

jumpcloud: map jumpcloud.event.changes as flattened #8298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2023
Merged

jumpcloud: map jumpcloud.event.changes as flattened #8298

merged 1 commit into from
Oct 27, 2023

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented Oct 26, 2023 •
edited
Loading

Proposed commit message

The API docs for the changes field gives it the type "Nested objects" and states that it cannot be searched on, so a flattended matches their semantics.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:jumpcloud JumpCloud (Community supported) labels Oct 26, 2023
@efd6 efd6 self-assigned this Oct 26, 2023
@efd6
jumpcloud: map jumpcloud.event.changes as flattened
7d7ddcf 
The API docs[1] for the changes field gives it the type "Nested objects" and states that it cannot be searched on, so a flattended matches their semantics. [1]https://docs.jumpcloud.com/api/insights/directory/1.0/index.html#section/Schemas
@elasticmachine
Copy link

elasticmachine commented Oct 26, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-26T07:13:04.019+0000

  • Duration: 15 min 36 sec

Test stats 🧪

Test Results
Failed 0
Passed 6
Skipped 0
Total 6

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine
Copy link

elasticmachine commented Oct 26, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 92.857% (13/14) 👍 8.135
Lines 71.004% (191/269) 👎 -25.61
Conditionals 100.0% (0/0) 💚
@efd6 efd6 marked this pull request as ready for review October 26, 2023 20:16
@efd6 efd6 requested a review from a team as a code owner October 26, 2023 20:16
@elasticmachine
Copy link

elasticmachine commented Oct 26, 2023

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
@efd6 efd6 merged commit 790e6a9 into elastic:main Oct 27, 2023
@elasticmachine
Copy link

elasticmachine commented Oct 27, 2023

Package jumpcloud - 1.7.1 containing this change is available at https://epr.elastic.co/search?package=jumpcloud
@efd6 efd6 deleted the 8253-jumpcloud branch February 5, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Integration:jumpcloud JumpCloud (Community supported)

3 participants

@efd6 @elasticmachine @chemamartinez