Skip to content

Conversation

@harnish-crest-data
Copy link
Contributor

  • Enhancement

What does this PR do?

This PR adds metric_type mapping for the fields of the driver data stream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

To verify the metric_type, please refer to the below mbeans type that is used for data collection

driver_mbean.txt

@harnish-crest-data harnish-crest-data added the enhancement New feature or request label Oct 6, 2023
@harnish-crest-data harnish-crest-data self-assigned this Oct 6, 2023
@harnish-crest-data harnish-crest-data marked this pull request as ready for review October 6, 2023 05:18
@harnish-crest-data harnish-crest-data requested a review from a team as a code owner October 6, 2023 05:18
…into apache_spark-driver-add-metric_type Conflicts:	packages/apache_spark/changelog.yml
@elasticmachine
Copy link

elasticmachine commented Oct 6, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-12T12:21:32.564+0000

  • Duration: 19 min 55 sec

Test stats 🧪

Test Results
Failed 0
Passed 15
Skipped 0
Total 15

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Oct 6, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚
Classes 100.0% (0/0) 💚
Methods 75.0% (12/16)
Lines 100.0% (0/0) 💚
Conditionals 100.0% (0/0) 💚
Copy link
Contributor

@ali786XI ali786XI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agithomas
Copy link
Contributor

@harnish-elastic , similar to #7794, is there a source of metric_type you have for reference?

@harnish-crest-data
Copy link
Contributor Author

harnish-crest-data commented Oct 9, 2023

@harnish-elastic , similar to #7794, is there a source of metric_type you have for reference?

@agithomas Since the MBean list is too large to mention in the PR description, I have already attached the file of the metric_type in the description itself.

Copy link
Contributor

@agithomas agithomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

…into apache_spark-driver-add-metric_type Conflicts:	packages/apache_spark/changelog.yml	packages/apache_spark/docs/README.md	packages/apache_spark/manifest.yml
@harnish-crest-data harnish-crest-data merged commit 620f766 into elastic:main Oct 13, 2023
@elasticmachine
Copy link

Package apache_spark - 0.7.3 containing this change is available at https://epr.elastic.co/search?package=apache_spark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:apache_spark Apache Spark

5 participants