Skip to content

[Google workspace] Fix saml NaN error #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2021
Merged

[Google workspace] Fix saml NaN error #809

merged 1 commit into from
Mar 29, 2021

Conversation

@marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Mar 26, 2021

What does this PR do?

Fixes a bad conversion for saml status code field.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
@marc-gr marc-gr added bug Something isn't working, use only for issues Team:Security-External Integrations labels Mar 26, 2021
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
@elasticmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #809 opened

  • Start Time: 2021-03-26T14:43:52.046+0000

  • Duration: 22 min 47 sec

  • Commit: 06e3f6f

Test stats 🧪

Test Results
Failed 0
Passed 24
Skipped 0
Total 24

Trends 🧪

Image of Build Times

Image of Tests
P1llus
P1llus approved these changes Mar 29, 2021
View reviewed changes
Copy link
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@marc-gr marc-gr merged commit 4110eef into elastic:master Mar 29, 2021
@marc-gr marc-gr deleted the google_workspace_fixes branch March 29, 2021 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues

3 participants

@marc-gr @elasticmachine @P1llus