Skip to content

[ECS] Updating okta to ECS 8.10 & ECS field validation updates #7930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 22, 2023
Merged

[ECS] Updating okta to ECS 8.10 & ECS field validation updates #7930

merged 5 commits into from
Sep 22, 2023

Conversation

@kgeller
Copy link
Contributor

@kgeller kgeller commented Sep 22, 2023 •
edited
Loading

What does this PR do?

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues
@kgeller kgeller added bug Something isn't working, use only for issues enhancement New feature or request Team:Security-External Integrations Integration:okta Okta labels Sep 22, 2023
@kgeller kgeller self-assigned this Sep 22, 2023
@elasticmachine
Copy link

elasticmachine commented Sep 22, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-22T17:37:21.289+0000

  • Duration: 16 min 28 sec

Test stats 🧪

Test Results
Failed 0
Passed 8
Skipped 0
Total 8

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@kgeller
Copy link
Contributor Author

kgeller commented Sep 22, 2023

/test
1 similar comment
@kgeller
Copy link
Contributor Author

kgeller commented Sep 22, 2023

/test
taylor-swanson
taylor-swanson approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@taylor-swanson taylor-swanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once tests actually run and pass (test failure is unrelated to these changes)
@kgeller
Copy link
Contributor Author

kgeller commented Sep 22, 2023

/test
@kgeller kgeller marked this pull request as ready for review September 22, 2023 14:58
@kgeller kgeller requested a review from a team as a code owner September 22, 2023 14:58
@elasticmachine
Copy link

elasticmachine commented Sep 22, 2023

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
@elasticmachine
Copy link

elasticmachine commented Sep 22, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (19/19) 💚 2.178
Lines 92.026% (577/627) 👍 4.348
Conditionals 100.0% (0/0) 💚
@taylor-swanson
Copy link
Contributor

taylor-swanson commented Sep 22, 2023

Looks like the latest test failure is caused by an outdated sample event file. Running the system test with the generate flag should clear that up.
@kgeller kgeller merged commit 711106f into elastic:main Sep 22, 2023
@kgeller kgeller deleted the okta-ecs8.10-updates branch September 22, 2023 18:02
@elasticmachine
Copy link

elasticmachine commented Sep 22, 2023

Package okta - 2.1.0 containing this change is available at https://epr.elastic.co/search?package=okta
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues enhancement New feature or request Integration:okta Okta

3 participants

@kgeller @elasticmachine @taylor-swanson