Skip to content

[ECS] Updating cisco_asa to ECS 8.10 & ECS field validation updates #7907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kgeller merged 7 commits into from
Sep 22, 2023
Merged

[ECS] Updating cisco_asa to ECS 8.10 & ECS field validation updates #7907

kgeller merged 7 commits into from
Sep 22, 2023

Conversation

@kgeller
Copy link
Contributor

@kgeller kgeller commented Sep 21, 2023

What does this PR do?

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues
@kgeller kgeller added bug Something isn't working, use only for issues enhancement New feature or request Team:Security-External Integrations labels Sep 21, 2023
@kgeller kgeller self-assigned this Sep 21, 2023
@elasticmachine
Copy link

elasticmachine commented Sep 21, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-22T03:01:05.509+0000

  • Duration: 16 min 24 sec

Test stats 🧪

Test Results
Failed 0
Passed 23
Skipped 0
Total 23

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine
Copy link

elasticmachine commented Sep 21, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚 1.481
Classes 100.0% (1/1) 💚 1.481
Methods 94.444% (17/18) 👎 -3.204
Lines 69.77% (1544/2213) 👎 -23.85
Conditionals 100.0% (0/0) 💚
@kgeller kgeller marked this pull request as ready for review September 21, 2023 03:00
@kgeller kgeller requested a review from a team as a code owner September 21, 2023 03:00
@elasticmachine
Copy link

elasticmachine commented Sep 21, 2023

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
@kgeller kgeller added the Integration:cisco_asa Cisco ASA label Sep 22, 2023
taylor-swanson
taylor-swanson reviewed Sep 22, 2023
View reviewed changes
packages/cisco_asa/manifest.yml
name: cisco_asa
title: Cisco ASA
version: "2.22.0"
version: "2.23.0"
Copy link
Contributor

@taylor-swanson taylor-swanson Sep 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we want to consider this a major version update since event.type was changed?
@kgeller kgeller merged commit f0876f4 into elastic:main Sep 22, 2023
@kgeller kgeller deleted the ciscoasa-ecs8.10-updates branch September 22, 2023 14:44
@kgeller kgeller mentioned this pull request Sep 22, 2023
Closed
4 tasks
@elasticmachine
Copy link

elasticmachine commented Sep 22, 2023

Package cisco_asa - 2.23.0 containing this change is available at https://epr.elastic.co/search?package=cisco_asa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues enhancement New feature or request Integration:cisco_asa Cisco ASA

4 participants

@kgeller @elasticmachine @andrewkroh @taylor-swanson