prevent 7.12 Fleet-Server package usage to avoid future / upgrade bugs #788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
EricDavisX requested review from aleksmaus, blakerouse, nchaulet, ph and scunningham EricDavisX changed the title 
| it only took a few mins to put this together for us to chat it. if you don't want to make the change that is ok, just close it out. |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
ph previously requested changes Mar 11, 2021
Thx - it is done and I synced the manifest and changelog, too. |
andresrc added the Team:Elastic-Agent | Pinging @elastic/agent (Team:Agent) |
ph approved these changes Mar 15, 2021
aleksmaus approved these changes Mar 15, 2021
| jenkins run the tests please |
| thanks Marcin. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is that gray area of both:
came out of discussion in #787
What does this PR do?
It sets the manifest to be ^7.13 so we don't end up with accidental 7.12 usage and have to deal with SDH / upgrade bugs when folks go from 7.12 to 7.13 and DO want to use Fleet Server
Checklist
- [ ] I have reviewed tips for building integrations and this pull request is aligned with them.- [ ] I have verified that all data streams collect metrics or logs.changelog.ymlfile.Author's Checklist
Anyone disagree or see that it would be a problem to better avoid this usage?
How to test this PR locally
after it is promoted / merged, make sure it does not appear for 7.12 BC / or shipped stacks