Skip to content

[hid_bravura_monitor] Use ECS definition for message and tags #7873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andrewkroh merged 1 commit into from
Sep 20, 2023
Merged

[hid_bravura_monitor] Use ECS definition for message and tags #7873

andrewkroh merged 1 commit into from
Sep 20, 2023

Conversation

@andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Sep 19, 2023 •
edited
Loading

What does this PR do?

For field type consistency, use the ECS value for message and tags.

Also fix an inconsistency between the data streams for the processors variable description.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
@andrewkroh andrewkroh added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:hid_bravura_monitor Bravura Monitor (Partner supported) labels Sep 19, 2023
@andrewkroh andrewkroh requested a review from a team as a code owner September 19, 2023 15:12
@elasticmachine
Copy link

elasticmachine commented Sep 19, 2023

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
@elasticmachine
Copy link

elasticmachine commented Sep 19, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-19T20:13:15.251+0000

  • Duration: 15 min 55 sec

Test stats 🧪

Test Results
Failed 0
Passed 51
Skipped 0
Total 51

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine
Copy link

elasticmachine commented Sep 19, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚 5.772
Classes 100.0% (2/2) 💚 5.772
Methods 92.0% (23/25) 👍 0.591
Lines 98.239% (502/511) 👍 11.19
Conditionals 100.0% (0/0) 💚
@andrewkroh
[hid_bravura_monitor] Use ECS definition for message and tags
16721db 
For field type consistency, use the ECS value for `message` and `tags`. Also fix an inconsistency between the data streams for the `processors` variable declaration.
@andrewkroh andrewkroh merged commit 3ed51bb into elastic:main Sep 20, 2023
@elasticmachine
Copy link

elasticmachine commented Sep 20, 2023

Package hid_bravura_monitor - 1.11.1 containing this change is available at https://epr.elastic.co/search?package=hid_bravura_monitor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Integration:hid_bravura_monitor Bravura Monitor (Partner supported)

3 participants

@andrewkroh @elasticmachine @efd6