Skip to content

[O11y][Apache Tomcat] Remove forwarded tag from metrics data streams #7824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 21, 2023
Merged

[O11y][Apache Tomcat] Remove forwarded tag from metrics data streams #7824

merged 2 commits into from
Sep 21, 2023

Conversation

@harnish-crest-data
Copy link
Contributor

@harnish-crest-data harnish-crest-data commented Sep 14, 2023

  • Bug

What does this PR do?

  • This PR removes the forwarded tag from the metricbeat-based data streams.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues
@harnish-crest-data harnish-crest-data added Integration:apache_tomcat Apache Tomcat bugfix Pull request that fixes a bug issue labels Sep 14, 2023
@harnish-crest-data harnish-crest-data self-assigned this Sep 14, 2023
@harnish-crest-data harnish-crest-data marked this pull request as ready for review September 14, 2023 12:39
@harnish-crest-data harnish-crest-data requested a review from a team as a code owner September 14, 2023 12:39
@harnish-crest-data harnish-crest-data mentioned this pull request Sep 14, 2023
Closed
7 tasks
@elasticmachine
Copy link

elasticmachine commented Sep 14, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-14T12:40:29.045+0000

  • Duration: 26 min 49 sec

Test stats 🧪

Test Results
Failed 0
Passed 54
Skipped 0
Total 54

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine
Copy link

elasticmachine commented Sep 14, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (9/9) 💚
Files 100.0% (9/9) 💚
Classes 100.0% (9/9) 💚
Methods 95.062% (77/81) 👍 70.062
Lines 79.846% (931/1166) 👎 -20.154
Conditionals 100.0% (0/0) 💚
ishleenk17
ishleenk17 approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@ishleenk17 ishleenk17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
@harnish-crest-data harnish-crest-data merged commit 0bf03f6 into elastic:main Sep 21, 2023
@elasticmachine
Copy link

elasticmachine commented Sep 21, 2023

Package apache_tomcat - 0.12.2 containing this change is available at https://epr.elastic.co/search?package=apache_tomcat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:apache_tomcat Apache Tomcat

3 participants

@harnish-crest-data @elasticmachine @ishleenk17