Skip to content

[ProblemChild] Update Blog Post Link in Docs and Minor Bug Fixes #7618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Sep 1, 2023
Merged

[ProblemChild] Update Blog Post Link in Docs and Minor Bug Fixes #7618

merged 11 commits into from
Sep 1, 2023

Conversation

@MakoWish
Copy link
Contributor

@MakoWish MakoWish commented Aug 30, 2023 •
edited
Loading

Type of change

  • Enhancement

What does this PR do?

This PR updates the blog post link in the ProblemChild integration's docs.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have incremented the version in my package's manifest.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues
@MakoWish MakoWish marked this pull request as ready for review August 30, 2023 17:38
@MakoWish MakoWish requested review from a team as code owners August 30, 2023 17:38
@MakoWish MakoWish changed the title Problem child documentation link [ProblemChild] Update Blog Post Link in Docs Aug 30, 2023
@MakoWish MakoWish mentioned this pull request Aug 30, 2023
Closed
5 tasks
@elasticmachine
Copy link

elasticmachine commented Aug 30, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-31T16:32:09.847+0000

  • Duration: 14 min 51 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@susan-shu-c
Copy link
Member

susan-shu-c commented Aug 30, 2023

/test
peteharverson
peteharverson approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for ML
ajosh0504
ajosh0504 reviewed Aug 31, 2023
View reviewed changes
ajosh0504
ajosh0504 reviewed Aug 31, 2023
View reviewed changes
ajosh0504
ajosh0504 reviewed Aug 31, 2023
View reviewed changes
MakoWish and others added 4 commits August 31, 2023 10:17
@MakoWish @ajosh0504
Commit changes from code review
83dd531 
Co-authored-by: Apoorva Joshi <30438249+ajosh0504@users.noreply.github.com>
@MakoWish @ajosh0504
Commit changes from code review
ed350f2 
Co-authored-by: Apoorva Joshi <30438249+ajosh0504@users.noreply.github.com>
@MakoWish
Consolidate #7521 and #7577 into #7618
6fc393d
@MakoWish
Merge branch 'problem_child_documentation_link' of https://github.com…
685e5f2 
…/MakoWish/integrations into problem_child_documentation_link
@MakoWish MakoWish mentioned this pull request Aug 31, 2023
Closed
5 tasks
susan-shu-c
susan-shu-c reviewed Aug 31, 2023
View reviewed changes
packages/problemchild/elasticsearch/ingest_pipeline/problem_child_inference_pipeline.yml
if:
ctx.containsKey('problemchild') && ctx['problemchild'].containsKey('prediction')
&& ctx['problemchild']['prediction'] == 0
&& ctx['problemchild']['prediction'] == '0'
Copy link
Member

@susan-shu-c susan-shu-c Aug 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajosh0504 does this look good? The rest of these changes are good to me
Copy link
Contributor

@ajosh0504 ajosh0504 Sep 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep this looks good!
ajosh0504
ajosh0504 approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@ajosh0504 ajosh0504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work. Thanks, @MakoWish! 🚀
packages/problemchild/elasticsearch/ingest_pipeline/problem_child_inference_pipeline.yml
if:
ctx.containsKey('problemchild') && ctx['problemchild'].containsKey('prediction')
&& ctx['problemchild']['prediction'] == 0
&& ctx['problemchild']['prediction'] == '0'
Copy link
Contributor

@ajosh0504 ajosh0504 Sep 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep this looks good!
@ajosh0504 ajosh0504 mentioned this pull request Sep 1, 2023
Merged
5 tasks
@susan-shu-c susan-shu-c merged commit 78d8776 into elastic:main Sep 1, 2023
@elasticmachine
Copy link

elasticmachine commented Sep 1, 2023

Package problemchild - 1.1.1 containing this change is available at https://epr.elastic.co/search?package=problemchild
@MakoWish MakoWish changed the title [ProblemChild] Update Blog Post Link in Docs [ProblemChild] Update Blog Post Link in Docs and Minor Bug Fixes Sep 1, 2023
@MakoWish MakoWish deleted the problem_child_documentation_link branch September 1, 2023 15:21
@andrewkroh andrewkroh added the Integration:problemchild Living off the Land Attack Detection label Jul 22, 2024
This was referenced Aug 20, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:problemchild Living off the Land Attack Detection

6 participants

@MakoWish @elasticmachine @susan-shu-c @peteharverson @ajosh0504 @andrewkroh