Skip to content

Conversation

@agithomas
Copy link
Contributor

@agithomas agithomas commented Aug 30, 2023

  • Enhancement

What does this PR do?

Add dimensions to query_index datastream

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  • 1. Build verification
    elastic-package build
    elastic-package stack up -v -d --services package-registry

  • 2. Document count verification after enablement

  • 3. Dashboard verification after enablement - Dashboard does not exist. All other dashboard panels rendering correctly.

  • 4. Index template verification

  • 5. Index mapping verification

  • 6. Index settings verification.

  • 7. Index rollover after TSDB disablement verification

Related issues

Screenshots

@agithomas agithomas changed the title Add dimensions mapping to query_index datastream [Couchbase] Add dimensions mapping to query_index datastream Aug 30, 2023
@agithomas
Copy link
Contributor Author

I could not find any related dashboards. So, skipping the dashboard tests.

@agithomas
Copy link
Contributor Author

Verified TSDB enablement

image

@agithomas
Copy link
Contributor Author

Index rollover testing

{ "acknowledged": true, "shards_acknowledged": true, "old_index": ".ds-metrics-couchbase.query_index-default-2023.08.30-000003", "new_index": ".ds-metrics-couchbase.query_index-default-2023.08.30-000004", "rolled_over": true, "dry_run": false, "conditions": {} } 
@agithomas agithomas marked this pull request as ready for review August 30, 2023 09:45
@agithomas agithomas requested a review from a team as a code owner August 30, 2023 09:45
@elasticmachine
Copy link

elasticmachine commented Aug 30, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-09-06T09:36:13.630+0000

  • Duration: 27 min 4 sec

Test stats 🧪

Test Results
Failed 0
Passed 45
Skipped 0
Total 45

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented Aug 30, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (10/10) 💚
Files 100.0% (10/10) 💚
Classes 100.0% (10/10) 💚
Methods 100.0% (72/72) 💚
Lines 100.0% (1076/1076) 💚
Conditionals 100.0% (0/0) 💚
Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@agithomas agithomas mentioned this pull request Sep 6, 2023
74 tasks
@agithomas agithomas merged commit ce1b3e0 into elastic:main Sep 6, 2023
@elasticmachine
Copy link

Package couchbase - 1.2.6 containing this change is available at https://epr.elastic.co/search?package=couchbase

@agithomas agithomas deleted the issue-7378-couchbase-queryindex-dim branch February 12, 2025 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants