Skip to content

fortigate_fortimail: handle block rule addition and removal #7191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
efd6 merged 2 commits into from
Jul 31, 2023
Merged

fortigate_fortimail: handle block rule addition and removal #7191

efd6 merged 2 commits into from
Jul 31, 2023

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented Jul 31, 2023

What does this PR do?

Parse out affected host IP when block rules are added or removed.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@efd6 efd6 added enhancement New feature or request Team:Security-External Integrations Integration:Fortinet (Deprecated) Use one of the specific fortinet_X labels. [Integration not found in source] labels Jul 31, 2023
@efd6 efd6 self-assigned this Jul 31, 2023
@efd6 efd6 force-pushed the 7180-fortigate_fortimail branch from de991bc to 9654ba4 Compare July 31, 2023 02:13
@efd6 efd6 mentioned this pull request Jul 31, 2023
Closed
@elasticmachine
Copy link

elasticmachine commented Jul 31, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-31T22:04:13.718+0000

  • Duration: 18 min 53 sec

Test stats 🧪

Test Results
Failed 0
Passed 17
Skipped 0
Total 17

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine
Copy link

elasticmachine commented Jul 31, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (7/7) 💚
Classes 100.0% (7/7) 💚
Methods 97.727% (43/44) ❕
Lines 92.391% (935/1012) ❕
Conditionals 100.0% (0/0) 💚
@efd6 efd6 marked this pull request as ready for review July 31, 2023 03:05
@efd6 efd6 requested a review from a team as a code owner July 31, 2023 03:05
@elasticmachine
Copy link

elasticmachine commented Jul 31, 2023

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
kcreddy
kcreddy approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼
@efd6 efd6 force-pushed the 7180-fortigate_fortimail branch from 9654ba4 to f783c48 Compare July 31, 2023 21:07
@efd6 efd6 merged commit 8a85ba1 into elastic:main Jul 31, 2023
@elasticmachine
Copy link

elasticmachine commented Jul 31, 2023

Package fortinet_fortimail - 2.6.0 containing this change is available at https://epr.elastic.co/search?package=fortinet_fortimail
@andrewkroh andrewkroh added Integration:fortinet_fortimail Fortinet FortiMail and removed Integration:Fortinet (Deprecated) Use one of the specific fortinet_X labels. [Integration not found in source] labels Jul 22, 2024
@efd6 efd6 deleted the 7180-fortigate_fortimail branch February 5, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:fortinet_fortimail Fortinet FortiMail

4 participants

@efd6 @elasticmachine @kcreddy @andrewkroh