Skip to content

Conversation

@kcreddy
Copy link
Contributor

@kcreddy kcreddy commented May 31, 2023

What does this PR do?

For some of the Audit and DNS logs, the @timestamp field is not being set in the pipeline. For DHCP, this is handled by copying from event.created in its own pipeline. This PR moves this logic into default pipeline

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Screenshots

@elasticmachine
Copy link

elasticmachine commented May 31, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-31T06:14:27.705+0000

  • Duration: 18 min 38 sec

Test stats 🧪

Test Results
Failed 0
Passed 21
Skipped 0
Total 21

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (4/4) 💚
Classes 100.0% (4/4) 💚
Methods 100.0% (37/37) 💚
Lines 93.558% (610/652)
Conditionals 100.0% (0/0) 💚
@kcreddy kcreddy self-assigned this May 31, 2023
@kcreddy kcreddy added Integration:infoblox_nios Infoblox NIOS bugfix Pull request that fixes a bug issue labels May 31, 2023
@kcreddy kcreddy marked this pull request as ready for review May 31, 2023 07:18
@kcreddy kcreddy requested a review from a team as a code owner May 31, 2023 07:18
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@kcreddy kcreddy merged commit 6ac8d61 into elastic:main May 31, 2023
agithomas pushed a commit to agithomas/integrations that referenced this pull request Jun 5, 2023
@kcreddy kcreddy deleted the sdh-3444-nios_dhcp_set_timestamp branch February 7, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug issue Integration:infoblox_nios Infoblox NIOS

3 participants