Skip to content

Conversation

@taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented May 30, 2023

What does this PR do?

This updates the crowdstrike integration to ECS 8.8.0. It was referencing elastic/ecs git@8.7 and using 8.7.0 in ingest pipelines. The pkg-spec version has also been updated to 2.7.0. This required the following changes to pipelines to be compliant:

  • Changing event.type from change to info in the falcon pipeline (auth_activity_audit.yml)
  • Normalizing threat.technique.name and thread.tactic.name to arrays in the falcon pipeline (detection_summary.yml)
  • Changing event.category from package to process for the HostedServiceStarted and HostedServiceStopped events in the fdr pipeline (default.yml)
[git-generate] go run github.com/andrewkroh/go-examples/ecs-update@latest -ecs-version=8.8.0 -ecs-git-ref=8.8 -format-version=2.7.0 packages/crowdstrike 

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

cd packages/crowdstrike elastic-package test 

Related issues

This updates the crowdstrike integration to ECS 8.8.0. It was referencing elastic/ecs git@8.8 and using 8.8.0 in ingest pipelines. [git-generate] go run github.com/andrewkroh/go-examples/ecs-update@latest -ecs-version=8.8.0 -ecs-git-ref=8.8 -format-version=2.7.0packages/crowdstrike
@elasticmachine
Copy link

elasticmachine commented May 30, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-30T18:15:02.690+0000

  • Duration: 15 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 16
Skipped 0
Total 16

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (9/9) 💚
Classes 100.0% (9/9) 💚
Methods 100.0% (56/56) 💚 5.882
Lines 95.227% (2793/2933) 👍 1.724
Conditionals 100.0% (0/0) 💚
@taylor-swanson taylor-swanson marked this pull request as ready for review May 31, 2023 13:04
@taylor-swanson taylor-swanson requested a review from a team as a code owner May 31, 2023 13:04
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

- append:
field: event.type
value: [change]
value: [info]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we conditionally add "allowed"/"denied" to this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least for event.category: authentication, the only allowed values are start, end, and info.

https://www.elastic.co/guide/en/ecs/current/ecs-allowed-values-event-category.html#ecs-event-category-authentication

@taylor-swanson taylor-swanson merged commit 8636c74 into elastic:main Jun 1, 2023
@elasticmachine
Copy link

Package crowdstrike - 1.13.0 containing this change is available at https://epr.elastic.co/search?package=crowdstrike

sodhikirti07 pushed a commit that referenced this pull request Jun 15, 2023
This updates the crowdstrike integration to ECS 8.8.0 and pkg-spec 2.7.0. It was referencing elastic/ecs git@8.7 and using 8.7.0 in ingest pipelines. - Changed event.type from change to info in the falcon pipeline (auth_activity_audit.yml) - Normalized threat.technique.name and thread.tactic.name to arrays in the falcon pipeline (detection_summary.yml) - Changed event.category from package to process for the HostedServiceStarted and HostedServiceStopped events in the fdr pipeline (default.yml) [git-generate] go run github.com/andrewkroh/go-examples/ecs-update@latest -ecs-version=8.8.0 -ecs-git-ref=8.8 -format-version=2.7.0 packages/crowdstrike
@taylor-swanson taylor-swanson deleted the pkg-spec-crowdstrike branch February 5, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:crowdstrike CrowdStrike

3 participants