Skip to content

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented May 12, 2023

What does this PR do?

Set host.os.type and host.os.family to windows in forwarded events.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

elasticmachine commented May 12, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-18T21:31:39.435+0000

  • Duration: 16 min 33 sec

Test stats 🧪

Test Results
Failed 0
Passed 129
Skipped 0
Total 129

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 12, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (4/4) 💚
Files 87.5% (7/8) 👎 -12.5
Classes 87.5% (7/8) 👎 -12.5
Methods 83.696% (77/92) 👎 -16.304
Lines 92.813% (5153/5552) 👎 -5.805
Conditionals 100.0% (0/0) 💚
@efd6 efd6 marked this pull request as ready for review May 12, 2023 02:56
@efd6 efd6 requested review from a team as code owners May 12, 2023 02:56
@efd6 efd6 requested review from fearful-symmetry and rdner May 12, 2023 02:56
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Since both fields are basically hard-coded, why do we need them both?
  2. Does this field exist for Linux and Mac too?
Copy link
Contributor Author

@efd6 efd6 May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that they are used in detection rules. Some rules will be based on family and some on name, it just happens that Windows was so good they named it twice.

Yes, these fields exist for other OSs, but they are not relevant here.

Copy link
Member

@ebeahan ebeahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after the changelog entry is updated.

@efd6 efd6 merged commit eceb653 into elastic:main May 18, 2023
@efd6 efd6 deleted the 6162-windows branch February 5, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:windows Windows

4 participants