Skip to content

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented May 4, 2023

What does this PR do?

Removes managed tag.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:system System labels May 4, 2023
@efd6 efd6 self-assigned this May 4, 2023
@elasticmachine
Copy link

elasticmachine commented May 4, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-05-05T04:41:56.907+0000

  • Duration: 15 min 41 sec

Test stats 🧪

Test Results
Failed 0
Passed 145
Skipped 0
Total 145

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

elasticmachine commented May 4, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (3/3) 💚
Files 100.0% (4/4) 💚 2.829
Classes 100.0% (4/4) 💚 2.829
Methods 60.759% (48/79) 👎 -31.906
Lines 99.535% (2780/2793) 👍 7.159
Conditionals 100.0% (0/0) 💚
@efd6 efd6 marked this pull request as ready for review May 4, 2023 22:44
@efd6 efd6 requested review from a team as code owners May 4, 2023 22:44
@efd6 efd6 requested review from fearful-symmetry and rdner May 4, 2023 22:44
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@@ -1,15 +0,0 @@
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing this! For context, Fleet installs and attaches two tags to Kibana assets when a package is installed: Managed and {package name}. This is to differentiate managed integration assets from normal dashboards etc because the behavior is different (they get overridden on package upgrades).

The other tag with ID system-fleet-pkg-system-default should also be removed. Did elastic-package export dashboards not strip this one? @mrodm, shouldn't the changes in elastic/elastic-package#1206 have caught this pattern as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It didn't strip either of them; I had to manually remove the tag. I can do that for the other as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Collaborator

@mrodm mrodm May 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What version of elastic-package was used to export that dashboard?
That was released in version v0.78.0 of elastic-package. Could it be that it was exported with an older version ?

Just tested to export that dashboard with elastic-package v0.78.0 and it removes the tags from the dashboard:

@@ -883,16 +883,6 @@ "id": "system-eb0039f0-fa7f-11e6-a1df-a78bd7504d38", "name": "edc0a4ad-a2f9-4ae8-93ca-cfd7d0ed40fe:search_0", "type": "search" - }, - { - "id": "system-fleet-managed-default", - "name": "tag-ref-fleet-managed-default", - "type": "tag" - }, - { - "id": "system-fleet-pkg-system-default", - "name": "tag-ref-fleet-pkg-system-default", - "type": "tag" }

Command used: elastic-package export dashboard --id system-0d3f2380-fa78-11e6-ae9b-81e5311e8cab

Just a note, elastic-package export dashboard does not remove the tags files (kibana/tags/*). Those tags could be used by other dashboards and it could break it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Command used: elastic-package export dashboard --id system-0d3f2380-fa78-11e6-ae9b-81e5311e8cab

Just a note, elastic-package export dashboard does not remove the tags files (kibana/tags/*). Those tags could be used by other dashboards and it could break it.

This was the issue. I did not find instruction indicating otherwise, so I used the standard export.

@efd6 efd6 merged commit 4d33ea6 into elastic:main May 5, 2023
@elasticmachine
Copy link

Package system - 1.27.1 containing this change is available at https://epr.elastic.co/search?package=system

@efd6 efd6 deleted the 6096-system branch February 5, 2025 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Integration:system System

5 participants