panw: allow dollar sign at the end of a user name #5886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
efd6 added bug 
This allows a use where machine accounts are tagged in Active Directory with a dollar sign[1]. [1]https://knowledgebase.paloaltonetworks.com/KCSArticleDetail?id=kA14u000000oN0iCAE&lang=en_US%E2%80%A9&refURL=http%3A%2F%2Fknowledgebase.paloaltonetworks.com%2FKCSArticleDetail
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
🌐 Coverage report
|
| Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
andrewkroh approved these changes Apr 18, 2023
| - '^%{USERNAME:source.user.name}@%{HOSTNAME:source.user.domain}$' | ||
| - '^%{USERNAME:source.user.name}$' | ||
| pattern_definitions: | ||
| USERNAMEM: '%{USERNAME}[$]?' |
Member
There was a problem hiding this comment.
Just curious, what is the significance of this pattern name "USERNAMEM"?
| Package panw - 3.7.1 containing this change is available at https://epr.elastic.co/search?package=panw |
bhapas pushed a commit to bhapas/integrations that referenced this pull request Apr 19, 2023
This allows a use where machine accounts are tagged in Active Directory with a dollar sign[1]. [1]https://knowledgebase.paloaltonetworks.com/KCSArticleDetail?id=kA14u000000oN0iCAE&lang=en_US%E2%80%A9&refURL=http%3A%2F%2Fknowledgebase.paloaltonetworks.com%2FKCSArticleDetail
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This allows a use where machine accounts are tagged in Active Directory with a dollar sign[1].
[1]https://knowledgebase.paloaltonetworks.com/KCSArticleDetail?id=kA14u000000oN0iCAE&lang=en_US%E2%80%A9&refURL=http%3A%2F%2Fknowledgebase.paloaltonetworks.com%2FKCSArticleDetail
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots