- Notifications
You must be signed in to change notification settings - Fork 513
[ZScaler ZPA] Fix PosturesHit and PosturesMiss parsing #5565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ZScaler ZPA] Fix PosturesHit and PosturesMiss parsing #5565
Conversation
…s only on String values
…ss only on ArrayList values
| Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
| /test |
| @srilumpa can you update the version under manifest.yml to "1.5.3". Otherwise its failing our CI checks |
| My bad, I forgot to update this field too. |
| /test |
🌐 Coverage report
|
andrewkroh left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. What version of ZPA are you running where you observed the Postures{Hit,Miss} that were lists? Did the format of these fields change between versions?
| Unfortunately, I can't tell you as I don't have those informations. We transmitted the configuration requested by the Elastic's integration documentation to the ones in charge of the appliance configuration and they configured the log forwarding accordingly. I don't think there were any version changes since then. |
| Hello, I have just updated the branch with the last main version and fix the conflicts. Are there some additional steps or missing informations that I could provide to proceed with this PR? |
bhapas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| Package zscaler_zpa - 1.6.1 containing this change is available at https://epr.elastic.co/search?package=zscaler_zpa |
What does this PR do?
As described in #5537, ZScaler Private Access Postures fields are not properly parsed and the related processors fail silently. This PR fixes this by checking if the field is a string or a list and apply the adequate processor.
Checklist
changelog.ymlfile.Author's Checklist
PosturesHitandPosturesMissas Strings (current behaviour)PosturesHitandPosturesMissas Lists (expected behaviour)How to test this PR locally
elastic-package.exe stack up -v -d\elastic-package stack shellinitelastic-package.exe test pipeline -vRelated issues