Skip to content

modsecurity: relax timestamp parsing and improve error handling #5418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2023
Merged

modsecurity: relax timestamp parsing and improve error handling #5418

merged 1 commit into from
Mar 8, 2023

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented Feb 28, 2023

What does this PR do?

Improves coverage of timestamp types and error handling.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@efd6 efd6 added bug Something isn't working, use only for issues enhancement New feature or request Team:Security-External Integrations labels Feb 28, 2023
@efd6 efd6 self-assigned this Feb 28, 2023
@elasticmachine
Copy link

elasticmachine commented Feb 28, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-28T22:36:34.098+0000

  • Duration: 15 min 11 sec

Test stats 🧪

Test Results
Failed 0
Passed 7
Skipped 0
Total 7

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (3/3) 💚 3.221
Classes 100.0% (3/3) 💚 3.221
Methods 100.0% (30/30) 💚 8.845
Lines 91.582% (359/392) 👎 -0.428
Conditionals 100.0% (0/0) 💚
@efd6 efd6 marked this pull request as ready for review March 1, 2023 00:07
@efd6 efd6 requested a review from a team as a code owner March 1, 2023 00:07
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
kcreddy
kcreddy approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼
@efd6 efd6 merged commit 936404f into elastic:main Mar 8, 2023
@elasticmachine
Copy link

Package modsecurity - 1.6.0 containing this change is available at https://epr.elastic.co/search?package=modsecurity
1 similar comment
@elasticmachine
Copy link

Package modsecurity - 1.6.0 containing this change is available at https://epr.elastic.co/search?package=modsecurity
agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 20, 2023
@efd6 @agithomas
modsecurity: relax timestamp parsing and improve error handling (elas…
c1234e8 
…tic#5418)
agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 21, 2023
@efd6 @agithomas
modsecurity: relax timestamp parsing and improve error handling (elas…
b6764de 
…tic#5418)
@efd6 efd6 deleted the 5404-modsecurity branch February 5, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues enhancement New feature or request

3 participants

@efd6 @elasticmachine @kcreddy