Skip to content

cisco_asa: allow user to retain searchable log message #5393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
efd6 merged 2 commits into from
Mar 8, 2023
Merged

cisco_asa: allow user to retain searchable log message #5393

efd6 merged 2 commits into from
Mar 8, 2023

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented Feb 27, 2023

What does this PR do?

Provides an option to allow the user to retain a searchable copy of the log message.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots
@efd6 efd6 self-assigned this Feb 27, 2023
@elasticmachine
Copy link

elasticmachine commented Feb 27, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-08T10:20:22.129+0000

  • Duration: 16 min 17 sec

Test stats 🧪

Test Results
Failed 0
Passed 23
Skipped 0
Total 23

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine
Copy link

elasticmachine commented Feb 27, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (1/1) 💚
Files 100.0% (1/1) 💚
Classes 100.0% (1/1) 💚
Methods 100.0% (18/18) 💚 66.667
Lines 85.143% (1851/2174) 👎 -14.857
Conditionals 100.0% (0/0) 💚
@efd6 efd6 marked this pull request as ready for review February 27, 2023 09:24
@efd6 efd6 requested a review from a team as a code owner February 27, 2023 09:24
@elasticmachine
Copy link

elasticmachine commented Feb 27, 2023

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
kcreddy
kcreddy approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor confirmation. Rest LGTM 👍🏼
packages/cisco_asa/data_stream/log/elasticsearch/ingest_pipeline/default.yml Outdated
Copy link
Contributor

@kcreddy kcreddy Mar 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to avoid ignore_failure?
Copy link
Contributor Author

@efd6 efd6 Mar 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done
@efd6 efd6 force-pushed the 5249-cisco_asa branch from b4f5445 to 72196e1 Compare March 8, 2023 10:20
@efd6 efd6 merged commit 0a55fd4 into elastic:main Mar 8, 2023
@elasticmachine
Copy link

elasticmachine commented Mar 8, 2023

Package cisco_asa - 2.14.0 containing this change is available at https://epr.elastic.co/search?package=cisco_asa
agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 20, 2023
@efd6 @agithomas
cisco_asa: allow user to retain searchable log message (elastic#5393)
322ebfb
agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 21, 2023
@efd6 @agithomas
cisco_asa: allow user to retain searchable log message (elastic#5393)
e712090
@efd6 efd6 deleted the 5249-cisco_asa branch February 5, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Integration:cisco_asa Cisco ASA

3 participants

@efd6 @elasticmachine @kcreddy