Skip to content

network_traffic: fix type of real_ip_header option for HTTP data stream #5362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2023
Merged

network_traffic: fix type of real_ip_header option for HTTP data stream #5362

merged 1 commit into from
Feb 23, 2023

Conversation

@efd6
Copy link
Contributor

@efd6 efd6 commented Feb 23, 2023 •
edited
Loading

What does this PR do?

Fixes type of real_ip_header option for HTTP data stream.

The backing configuration expects a string, not a bool.

https://github.com/elastic/beats/blob/1f1868d6b1c98d9b9b995e6ffbb3772b8ee293b1/packetbeat/protos/http/config.go#L31

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Screenshot 2023-02-23 at 12 43 25
@efd6 efd6 added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:network_traffic Network Packet Capture labels Feb 23, 2023
@efd6 efd6 self-assigned this Feb 23, 2023
@efd6 efd6 force-pushed the npc-real_ip_header branch from 0b15ea6 to b477e7f Compare February 23, 2023 02:18
@elasticmachine
Copy link

elasticmachine commented Feb 23, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-23T03:59:49.162+0000

  • Duration: 70 min 23 sec

Test stats 🧪

Test Results
Failed 0
Passed 173
Skipped 0
Total 173

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@elasticmachine
Copy link

elasticmachine commented Feb 23, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 3.432
Classes 100.0% (0/0) 💚 3.432
Methods 71.875% (46/64) 👎 -19.277
Lines 100.0% (0/0) 💚 8.592
Conditionals 100.0% (0/0) 💚
@efd6
Copy link
Contributor Author

efd6 commented Feb 23, 2023

/test
@efd6 efd6 marked this pull request as ready for review February 23, 2023 05:52
@efd6 efd6 requested a review from a team as a code owner February 23, 2023 05:52
@elasticmachine
Copy link

elasticmachine commented Feb 23, 2023

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)
@efd6 efd6 merged commit 01131cd into elastic:main Feb 23, 2023
@elasticmachine
Copy link

elasticmachine commented Feb 23, 2023

Package network_traffic - 1.9.1 containing this change is available at https://epr.elastic.co/search?package=network_traffic
agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 20, 2023
@efd6 @agithomas
network_traffic: fix type of real_ip_header option for HTTP data stre…
8c142d2 
…am (elastic#5362)
agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 21, 2023
@efd6 @agithomas
network_traffic: fix type of real_ip_header option for HTTP data stre…
8e5de45 
…am (elastic#5362)
@efd6 efd6 deleted the npc-real_ip_header branch February 5, 2025 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Integration:network_traffic Network Packet Capture

3 participants

@efd6 @elasticmachine @P1llus