Skip to content

Conversation

@tdancheva
Copy link
Contributor

@tdancheva tdancheva commented Feb 20, 2023

What does this PR do?

Changed the default storage container names for both streams to avoid collisions with the Azure Firewall Logs integration

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

How to test this PR locally

The change can be seen by adding the integration and inspecting the corresponding agent policy (looking for storage_account_container under inputs).

Related issues

Screenshots

@tdancheva tdancheva requested a review from zmoog February 20, 2023 10:27
@tdancheva tdancheva added bug Something isn't working, use only for issues Team:Cloud-Monitoring Label for the Cloud Monitoring team labels Feb 20, 2023
@elasticmachine
Copy link

elasticmachine commented Feb 20, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-20T10:21:55.702+0000

  • Duration: 13 min 45 sec

Test stats 🧪

Test Results
Failed 0
Passed 9
Skipped 0
Total 9

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (2/2) 💚
Files 100.0% (2/2) 💚
Classes 100.0% (2/2) 💚
Methods 91.667% (22/24) 👍 66.667
Lines 100.0% (288/288) 💚
Conditionals 100.0% (0/0) 💚
@tdancheva tdancheva marked this pull request as ready for review February 20, 2023 10:59
@tdancheva tdancheva requested a review from a team as a code owner February 20, 2023 10:59
@zmoog
Copy link
Contributor

zmoog commented Feb 20, 2023

For the records, the current informal naming convention for the storage_account_container var is:

storage_account_container: <PREFIX>-<DATA_STREAM_NAME>-{{eventhub}} 

The storage_account_container value must be unique for each data stream and event hub.

In older integrations, the PREFIX is filebeat for backward compatibility. The prefix can be different for new integrations that don't have a counterpart in Beats.

@tdancheva tdancheva merged commit b880a6f into elastic:main Feb 20, 2023
@elasticmachine
Copy link

Package azure_frontdoor - 0.0.2 containing this change is available at https://epr.elastic.co/search?package=azure_frontdoor

agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 20, 2023
* Change default storage container name to avoid collision * bump up version
agithomas pushed a commit to agithomas/integrations that referenced this pull request Mar 21, 2023
* Change default storage container name to avoid collision * bump up version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working, use only for issues Team:Cloud-Monitoring Label for the Cloud Monitoring team

4 participants