Skip to content

[winlog] Add a couple ECS fields for error checking/codes #5273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 15, 2023
Merged

[winlog] Add a couple ECS fields for error checking/codes #5273

merged 5 commits into from
Feb 15, 2023

Conversation

@nicpenning
Copy link
Contributor

@nicpenning nicpenning commented Feb 14, 2023

  • Bug

What does this PR do?

Account for any ingest pipelines that might throw some error messages or event codes.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
@nicpenning nicpenning requested a review from a team as a code owner February 14, 2023 19:11
@elasticmachine
Copy link

elasticmachine commented Feb 14, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-15T05:05:29.666+0000

  • Duration: 14 min 43 sec

Test stats 🧪

Test Results
Failed 0
Passed 2
Skipped 0
Total 2

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.
@efd6
Copy link
Contributor

efd6 commented Feb 14, 2023

/test
efd6
efd6 reviewed Feb 15, 2023
View reviewed changes
@nicpenning
Copy link
Contributor Author

nicpenning commented Feb 15, 2023

Had a couple lingering spaces :/

Need to test again
@nicpenning
Copy link
Contributor Author

nicpenning commented Feb 15, 2023

/test
1 similar comment
@efd6
Copy link
Contributor

efd6 commented Feb 15, 2023

/test
@elasticmachine
Copy link

elasticmachine commented Feb 15, 2023

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 3.376
Classes 100.0% (0/0) 💚 3.376
Methods 66.667% (2/3) 👎 -24.516
Lines 100.0% (0/0) 💚 8.264
Conditionals 100.0% (0/0) 💚
efd6
efd6 approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks
@efd6 efd6 merged commit c9f3c19 into elastic:main Feb 15, 2023
@elasticmachine
Copy link

elasticmachine commented Feb 15, 2023

Package winlog - 1.12.0 containing this change is available at https://epr.elastic.co/search?package=winlog
@nicpenning nicpenning deleted the patch-5 branch February 15, 2023 12:14
@nicpenning
Copy link
Contributor Author

nicpenning commented Feb 15, 2023

No problem! 😀
bhapas pushed a commit to bhapas/integrations that referenced this pull request Feb 16, 2023
@nicpenning @bhapas
[winlog] Add ECS fields for error checking/codes (elastic#5273)
039c042 
Account for any ingest pipelines that might throw some error messages or event codes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@nicpenning @elasticmachine @efd6